[3.7] bpo-37885: venv: Don't produce unbound variable warning on deactivate (GH-15330)#15974
Merged
Merged
Conversation
…pythonGH-15330) Before, running deactivate from a bash shell configured to treat undefined variables as errors (`set -u`) would produce a warning: ``` $ python3 -m venv test $ source test/bin/activate (test) $ deactivate -bash: $1: unbound variable ``` (cherry picked from commit 5209e58) Co-authored-by: Daniel Abrahamsson <hamsson@gmail.com>
Contributor
Author
1 similar comment
Contributor
Author
MetricMike
added a commit
to MetricMike/asdf-awscli
that referenced
this pull request
Feb 9, 2021
pypa/virtualenv#1342 python/cpython#15974 venv deactivate fails with set -euo pipefail fixed in 3.7.5+
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before, running deactivate from a bash shell configured to treat undefined variables as errors (
set -u) would produce a warning:(cherry picked from commit 5209e58)
Co-authored-by: Daniel Abrahamsson hamsson@gmail.com
https://bugs.python.org/issue37885